Added ResourceConfiguration as parameter in NodeKind #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for opening this pull request and for helping to improve SirixDB 🚀 |
pernelkanic
changed the title
|
It seems it doesn't compile anymore |
|
@pernelkanic can you fix it? Would be a great contribution 👍 |
|
yeah sure! |
|
https://github.com/sirixdb/sirix/actions/runs/6595280725/job/17923052228?pr=672 I'm on my phone, but ghis is the log |
|
Still not compiling due to anothe issue!? Did it ever work for you? Running the tests locally? |
|
Can you fix the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PageKind , Removed the PageReadOnlyTrx parameter and added a ResourceConfiguration parameter for passing the necessary data required for serialization and deserialization.
#519